chore: move init_defaults to tempo-node crate for easier re-use in other binaries#2782
Open
zerosnacks wants to merge 3 commits intomainfrom
Open
chore: move init_defaults to tempo-node crate for easier re-use in other binaries#2782zerosnacks wants to merge 3 commits intomainfrom
init_defaults to tempo-node crate for easier re-use in other binaries#2782zerosnacks wants to merge 3 commits intomainfrom
Conversation
Move init_download_urls, init_payload_builder_defaults, init_txpool_defaults and the public init_defaults function from bin/tempo into crates/node/src/defaults.rs. Re-export init_defaults from tempo_node lib.rs alongside init_version_metadata. Telemetry CLI types (TelemetryArgs, UrlWithAuth, TelemetryConfig) remain in the tempo binary as they are CLI-specific. Amp-Thread-ID: https://ampcode.com/threads/T-019c76ac-cb19-70fd-aa37-75be4e69ea25 Co-authored-by: Amp <amp@ampcode.com>
zerosnacks
requested review from
0xKitsune,
SuperFluffy,
Zygimantass,
klkvr and
mattsse
as code owners
zerosnacks
changed the title
init_defaults to tempo-node crate for easier re-use in other binaries
Amp-Thread-ID: https://ampcode.com/threads/T-019c76ac-cb19-70fd-aa37-75be4e69ea25 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019c76ac-cb19-70fd-aa37-75be4e69ea25 Co-authored-by: Amp <amp@ampcode.com>
0xrusowsky
approved these changes
Feb 19, 2026
Contributor
0xrusowsky
left a comment
0xrusowsky
left a comment
There was a problem hiding this comment.
i don't see any problem with this, but let's wait for more reviewers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
init_download_urls,init_payload_builder_defaults,init_txpool_defaultsand the publicinit_defaultsfunction frombin/tempointocrates/node/src/defaults.rs.Re-export
init_defaultsfromtempo_nodelib.rs alongsideinit_version_metadata.Telemetry CLI types (
TelemetryArgs,UrlWithAuth,TelemetryConfig) remain in the tempo binary as they are CLI-specific.